-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter docker: upgrade birdy, pin pandas and geopandas for Era5 Raven notebooks #37
Conversation
…ed_data_subset.ipynb scikit-image need by that same notebook as well. This is most likely because salem do not work with geopandas >=0.7. Can try to un-pin geopandas and pandas with new salem release.
…upyterlab For Raven Region_selection.ipynb.
…as well, too much work Step 9/18 : RUN jupyter lab build ---> Running in 9593c434adfe [LabBuildApp] JupyterLab 1.2.5 [LabBuildApp] Building in /usr/local/envs/birdy/share/jupyter/lab [LabBuildApp] Building jupyterlab assets (build:prod:minimize) [LabBuildApp] WARNING | "[email protected]" is not compatible with the current JupyterLab Conflicting Dependencies: JupyterLab Extension Package >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/apputils >=3.2.0 <3.3.0 >=4.0.0 <5.0.0 @jupyterlab/coreutils >=1.2.2 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/notebook >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/rendermime >=4.2.0 <4.3.0 >=5.0.0 <6.0.0 @jupyterlab/services Removing intermediate container 9593c434adfe ---> 16c7a0cdd721 Step 10/18 : RUN jupyter labextension install @jupyter-widgets/jupyterlab-manager && jupyter serverextension enable voila --sys-prefix && jupyter labextension install @jupyter-widgets/jupyterlab-manager jupyter-leaflet ---> Running in 4f18a273aab9 Building jupyterlab assets (build:prod:minimize) "[email protected]" is not compatible with the current JupyterLab Conflicting Dependencies: JupyterLab Extension Package >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/apputils >=3.2.0 <3.3.0 >=4.0.0 <5.0.0 @jupyterlab/coreutils >=1.2.2 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/notebook >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/rendermime >=4.2.0 <4.3.0 >=5.0.0 <6.0.0 @jupyterlab/services Enabling: voila - Writing config: /usr/local/envs/birdy/etc/jupyter - Validating... voila 0.1.21 OK Building jupyterlab assets (build:prod:minimize) "[email protected]" is not compatible with the current JupyterLab Conflicting Dependencies: JupyterLab Extension Package >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/apputils >=3.2.0 <3.3.0 >=4.0.0 <5.0.0 @jupyterlab/coreutils >=1.2.2 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/notebook >=1.2.1 <1.3.0 >=2.0.0 <3.0.0 @jupyterlab/rendermime >=4.2.0 <4.3.0 >=5.0.0 <6.0.0 @jupyterlab/services Removing intermediate container 4f18a273aab9
@huard Looks like the new birdy broke Finch: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/install-birdy-from-source/2/console
|
Ok, this will be fixed in Finch itself. Will make a new release this week. |
Reference to Finch issue bird-house/finch#99, thanks David ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New birdy version (on pypi) should fix the Finch problem, but I'll update Finch as well to make sure.
Noticed one passing DockerHub build since we installed from source so maybe using pip to install might help. This is just a shoot in the dark.
Reference to birdy fix bird-house/birdy#175 |
@huard Jenkins test failed against the new Finch: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/install-birdy-from-source/4/console There is this error, easy to fix, just want to confirm it's expected:
Then there is this real error:
With Traceback from the Finch container:
|
Add reference to Finch update in PAVICS: bird-house/birdhouse-deploy#32 |
The first is expected. |
Latest birdy 0.6.9 is working flawlessly with existing old Finch 0.2.7 and existing recently released Raven 0.10.0. See Jenkins run http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/install-birdy-from-source/9/console for Finch testing. Raven test done manually. So I'll release this Jupyter env so at least the Raven notebooks works without manually hacking the Jupyter env. Old Finch is not broken anymore so no regression there. |
See PR Ouranosinc/PAVICS-e2e-workflow-tests#37 or commit Ouranosinc/PAVICS-e2e-workflow-tests@8bbb5b4 for more info. Noticeable Jupyter env changes: ```diff < - birdy=v0.6.6=py_0 > - birdhouse-birdy==0.6.9 (install from Pypi instead of Conda to fix DockerHub failure !) < - geopandas=0.7.0=py_1 > - geopandas=0.6.2=py_0 < - pandas=1.0.1=py37hb3f55d8_0 > - pandas=0.25.3=py37hb3f55d8_0 > - scikit-image=0.16.2=py37hb3f55d8_0 ```
This is to productize all the manual
pip install --user
we had to do to demo Era5 Raven notebook PR: Ouranosinc/raven#200birdy updated for Raven, then for Finch.
Pinning of pandas and geopandas is due to salem not supporting geopandas >= 0.7 as in this issue fmaussion/salem#152 so can unpin once there are new release of salem.
scikit-image was also need by Raven notebook
gridded_data_subset.ipynb
.The ipyleaflet marker do not display in Raven
Region_selection.ipynb
but can be moved and its coordinate can be extracted.Not sure why, maybe relate to jupyter-widgets/ipyleaflet#91. Possibly also due to the freshly released jupyterlab-2.0 but downgrading jupyterlab means downgrading all the other jupyter extensions we used, too much work to just fix one broken extension so did not follow that road.
The marker was working fine in the previous image
pavics/workflow-tests:200120
which had jupyterlab-1.2.5 which further support the theory that jupyterlab-2.0 broke it.Noticeable Jupyter env changes:
Full conda env export Diff:
200309-200310-conda-env-export.diff.txt
200309-200312-conda-env-export.diff.txt
200310-200312-conda-env-export.diff.txt
Full new conda env export:
200310-conda-env-export.yml.txt
200312-conda-env-export.yml.txt